Improve addTransaction performance and add calculateFee #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
requested review from
devbugging,
janezpodhostnik and
sisyphusSmiling
sisyphusSmiling
approved these changes
Dec 5, 2025
Comment on lines
+1057
to
1060
| if let priorityQueue = *slotQueue[txData.priority] { | ||
| priorityQueue[txData.id] = txData.executionEffort | ||
| slotQueue[txData.priority] = priorityQueue | ||
| } else { |
Contributor
There was a problem hiding this comment.
I was going to suggest that we avoid copying the priorityQueue mapping here but it looks like we can't get an auth(Mutate) reference to the inner mapping which is unfortunate. I would think the outer authorized reference enables us to access the inner values as authorized as well.
Member
Author
There was a problem hiding this comment.
yeah, I thought that would be true too, but I could see it potentially unintentionally exposing something.
devbugging
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some performance improvements to
addTransaction()to use references instead of copying and adds acalculateFee()function so that users can call that to calculate the fee instead of having to callestimate(), which is pretty costly